search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.92k stars 405 forks source link

Fleet UI: Update profile activity items copies to remove platform specificity from activity #20575

Closed RachelElysia closed 3 weeks ago

RachelElysia commented 1 month ago

Fleet version: <!-- Copy this from the "My account" page in the Fleet UI, or run fleetctl --version -->

Web browser and operating system:

💥  Actual behavior

The following activity items on the dashboard... createdDeclarationProfile deletedDeclarationProfile editedDeclarationProfile createMacOSProfile deleteMacOSProfile editMacOSProfile ...only mention "macOS" in the UI to the user, even though these activities apply to iOS and iPadOS profile activities as well.

🧑‍💻  Steps to reproduce

  1. Do an action to iOS/iPadOS profiles
  2. See that the activity is created talking only about macOS

🕯️ More info (optional)

Separating this from the current work that I found it on so we can push this bug to 4.54.1

Update Frontend variables and UI user facing text from "macOS" to "macOS, iOS, and iPadOS"

Product decision 7/24/24: Make all these copies platform agnostic.

New copies that do not include platform name (e.g. macOS, Windows, iPadOS, iOS):

Rachel Perkins added configuration profile Ensure Password Age Is Configured to all hosts. Rachel Perkins added configuration profile Ensure Password Age Is Configured to hosts on no team. Rachel Perkins added configuration profile Ensure Password Age Is Configured to the Workstations team.

Rachel Perkins edited configuration profile Ensure Password Age Is Configured on all hosts. Rachel Perkins edited configuration profile Ensure Password Age Is Configured on hosts on no team. Rachel Perkins edited configuration profile Ensure Password Age Is Configured for the Workstations team.

Rachel Perkins deleted configuration profile Ensure Password Age Is Configured from all hosts. Rachel Perkins deleted configuration profile Ensure Password Age Is Configured from hosts with no team. Rachel Perkins deleted configuration profile Ensure Password Age Is Configured from the Workstations team.

Rachel Perkins edited configuration profiles for all hosts via fleetctl. Rachel Perkins edited configuration profiles for hosts on no team via fleetctl. Rachel Perkins edited configuration profiles for the Workstations team via fleetctl.

RachelElysia commented 1 month ago

Confirmed with @lucasmrod that BE changes of activity names will be a beast so the fix should be FE code updates and user facing copy changes. cc: @noahtalerman

RachelElysia commented 1 month ago

Ooo @lucasmrod I found an activity that was renamed from including macos in it "enabled_disk_encryption" deprecated: "enabled_macos_disk_encryption"

@gillespi314 left this comment 5 months ago

// Note: Both "enabled_disk_encryption" and "enabled_macos_disk_encryption" display the same
// message. The latter is deprecated in the API but it is retained here for backwards compatibility.

Something to consider @noahtalerman for design

lucasmrod commented 1 month ago

Oh, good to know!

noahtalerman commented 1 month ago

Confirmed with @lucasmrod that BE changes of activity names will be a beast so the fix should be FE code updates and user facing copy changes.

Thanks @RachelElysia! This is helpful.

I think we can handle this in copy changes too.

I think let's plan to hit this during Tuesday's endpoint ops design review. We can do a live wireframing/coding session.

RachelElysia commented 1 month ago

@noahtalerman

I updated the ticket to match the decision from today's design review agenda . Please let me know if any of those copies look wonky to you, I just removed the reference to platforms.

noahtalerman commented 1 month ago

Thanks @RachelElysia!

Minor changes requested (copy and bold styles) are below. I updated the issue description to match what I think we want.

Rachel Perkins added configuration profile Ensure Password Age Is Configured to all hosts. Rachel Perkins added configuration profile Ensure Password Age Is Configured to hosts on no team.

Rachel Perkins edited configuration profile Ensure Password Age Is Configured on all hosts. Rachel Perkins edited configuration profile Ensure Password Age Is Configured on hosts on no team.

Rachel Perkins deleted configuration profile Ensure Password Age Is Configured from all hosts. Rachel Perkins deleted configuration profile Ensure Password Age Is Configured from hosts with no team.

Rachel Perkins edited configuration profiles for all hosts via fleetctl. Rachel Perkins edited configuration profiles for hosts on no team via fleetctl.

fleet-release commented 3 weeks ago

Across all platforms, Edits seen, profiles updated, Fleet's clarity blooms.