fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.11k stars 427 forks source link

Fleet UI: Host details page > About section can overflow #20683

Closed RachelElysia closed 3 weeks ago

RachelElysia commented 3 months ago

Fleet version: <!-- Copy this from the "My account" page in the Fleet UI, or run fleetctl --version -->

Web browser and operating system:


💥  Actual behavior

On the host details page, the About section is overflowing on the right side of the screen

Screenshot 2024-07-24 at 9 38 02 AM

🧑‍💻  Steps to reproduce

  1. Host details page of a really long email address
  2. Shrink page width

🕯️ More info (optional)

N/A

Have the div wrap instead of overflow

jacobshandling commented 3 months ago

@noahtalerman this and various related layout bugs are being caused by longer values for each of these pieces of data, for example the values of MDM server URL and Used by below:

Screenshot 2024-08-01 at 10.35.23 PM.png

Something(s) will have to give - what layout elements here do we want to be more flexible (could just be at lower viewport width) to accommodate, and how so? Some possibilities:

noahtalerman commented 3 months ago

Hey @jacobshandling! Thanks for laying out the options. what do you think we should do?

RachelElysia commented 1 month ago

Hey @jacobshandling! Thanks for laying out the options. what do you think we should do?

@noahtalerman I built a fix in #22257, check out the loom on the PR and lmkwyt!

noahtalerman commented 1 month ago

@RachelElysia looks good!

Do you know how we could improve this long dotted line?

Screenshot 2024-09-23 at 5 12 14 PM

Is there another way we indicate tooltip on hover today? Maybe italics?

Maybe we could borrow the italics styles (like from software page) and just show 2 users instead of the "really long user + more" UI Screenshot 2024-09-23 at 5 13 57 PM

fleet-release commented 3 weeks ago

Overflow tamed, content wraps, Fleet's web page breathes anew, Ease found in the gaps.