Software counts aren't updated on team transfer

[noahtalerman]

💥  Actual behavior

• On the Software titles page for a specific team, the failed/installed/pending counts include hosts that are no longer on that team (transferred). This occurs for packages and App Store apps.
• On the Host details > Software table and My device page, the "Install status" for software is stays present after a host is transferred. This is for packages and App Store apps.

🧑‍💻  Steps to reproduce

1. Install a package on a host in Team A
2. Transfer the host to Team B
3. Run vulnerabilities job.

🕯️ More info (optional)

For more info see this comment thread in a confidential issue here.

🛠️ To fix

• On the Software titles page, for the failed/installed/pending counts, only include hosts that are still part of that team. This is for packages and App Store apps.
• On the Host details > Software table and My device pages, only include "Install status" for software that are on the same team as the host's. This is for packages and App Store apps.
  • The user can still view the installation details if they click Actions > Show details (screenshot 1) or Show details in the Host details and global activity feed (screenshot 2)
  • UPDATE: @mna: This may be already fixed by https://github.com/fleetdm/fleet/issues/20730.
  • @noahtalerman: Nice! I think it's worth double checking when we address this bug.

[mna]

@noahtalerman for the second bullet in To Fix, I think the second one is already fixed by https://github.com/fleetdm/fleet/issues/20730.

I agree with the fix for the counts on the "Software titles" page.

[noahtalerman]

I think the second one is already fixed by https://github.com/fleetdm/fleet/issues/20730.

Nice!

[xpkoala]

This is confirmed fixed. Closing out.

[fleet-release]

Transferred teams gleam, Software counts now so clean, Fleet's cloud city dream.