search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.92k stars 409 forks source link

Document "assigned" reviewer convention #21401

Open iansltx opened 3 weeks ago

iansltx commented 3 weeks ago

Per https://fleetdm.slack.com/archives/C019WG4GH0A/p1724082858929979?thread_ts=1724075490.939379&cid=C019WG4GH0A, in addition to the reviewers requested specified in CODEOWNERS, a PR should be assigned to a single person to ensure it gets reviewed in a timely manner. This has been a convention in the endpoint ops team for awhile but appears to be undocumented (I'd expect this to be in either engineering or product groups handbook entries but see it in neither).

  1. Is this endpoint ops specific or does this convention extend to MDM?
  2. Am I right that one of the above places is where it should be documented?

/cc @sharon-fdm @georgekarrv @lukeheath

iansltx commented 3 weeks ago

As part of this, if the above is desired, this should be a 1:1 topic for onboarding on the engineering side, to ensure a new Fleetie's contributions don't sit around for too long.