fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.92k stars 409 forks source link

Gitops - applying config for Windows MDM erroring #21402

Open RachelElysia opened 3 weeks ago

RachelElysia commented 3 weeks ago

Fleet version: <!-- Copy this from the "My account" page in the Fleet UI, or run fleetctl --version -->

Web browser and operating system:


💥  Actual behavior

Trying to apply changes to the config of Windows MDM, a customer is getting this response:

Error: applying fleet config: PATCH /api/latest/fleet/config received status 422 Validation Failed: Couldn't edit windows_settings.custom_settings. Windows MDM isn't turned on. Visit https://fleetdm.com/docs/using-fleet to learn how to turn on MDM.

However, their Windows MDM is enabled (even sent a screenshot of the UI showing its enabled).

🧑‍💻  Steps to reproduce

  1. TODO
  2. TODO

🕯️ More info (optional)

N/A

ksatter commented 3 weeks ago

This was resolved by updating the default configuration to include controls.windows_enabled_and_configured: true

georgekarrv commented 3 weeks ago

We could probably try to improve this error message to point to the solution though. Gonna leave it open for now

jahzielv commented 1 week ago

@georgekarrv does this need product input before someone picks it up to fix?

PezHub commented 3 days ago

QA Notes: I see the updated and improved error with additional details that points the user to our URLs

gitops -f ~/fleetdm/gitops/default.yaml                                    01:09:03 PM
Error: applying fleet config: PATCH /api/latest/fleet/config received status 422 Validation Failed: Couldn’t edit windows_settings.custom_settings. Windows MDM isn’t turned on. This can be enabled by setting "controls.windows_enabled_and_configured: true" in the default configuration. Visit https://fleetdm.com/guides/windows-mdm-setup and https://fleetdm.com/docs/configuration/yaml-files#controls to learn more about enabling MDM.