search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.93k stars 409 forks source link

Refactor 'nanodep' client to be able to use multiple ABM tokens #21500

Open roperzh opened 3 weeks ago

roperzh commented 3 weeks ago

Goal

User story
As an engineer working in Fleet MDM features,
I want to use a client to talk to ABM with multiple tokens
so that I can develop features in a fast paced environment.

We're currently using a hack by embedding the right token in the context, but this is dangerous because:

  1. It's an unexpected way to pass parameters, it will inevitably lead to bugs
  2. It's confusing for new people onboarding

Context

Engineering

QA

Risk assessment

Manual testing steps

  1. Smoke test of multiple ABM tokens

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
lukeheath commented 3 weeks ago

@roperzh Thanks for filing! This looks like something we need to do sooner rather than later to ensure the stability of multiple ABM functionality.

@georgekarrv I've added the ~eng-priority label to indicate this is a high priority ticket for us that we should do our best to prioritize.

georgekarrv commented 2 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @roperzh @gillespi314 @mna @jahzielv @dantecatalfamo

noahtalerman commented 2 weeks ago

Hey @lukeheath and @georgekarrv if I'm understanding correctly, we didn't have room for this story in the sprint we just kicked off.

As part of the sprint kickoff review ritual, we remove all stories (including eng initiated) that didn't make it into the sprint. We forgot to do this live on the call today.

Since this one has the ~eng-priority label, should we leave this one on the drafting board? (instead of removing and re-adding)

More generally, should we leave stories with the ~eng-priority label or remove and leave it up to the Architecture DRI (Luke) to add it back when reviewing eng initiated stories?

I left it on the board for now.

lukeheath commented 2 weeks ago

@noahtalerman Thanks for checking! This is a new label I added so that I could remember which stories had been prioritized and estimated, but didn't make it into the sprint. It's okay to remove them, I'll use this label to remember which ones I need to bring back.