fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.93k stars 409 forks source link

Terraform module refers to an older RDS aurora engine version. #21547

Closed rfairburn closed 2 weeks ago

rfairburn commented 3 weeks ago

*Terraform module version**: tf-mod-root-v1.11.0


💥  Actual behavior

AWS automatically updates the aurora version to a newer version than what the module includes and subsequent applies will give an error trying to upgrade aurora-mysql from 8.0.mysql_aurora.3.05.2 to 8.0.mysql_aurora.3.04.2, which is a downgrade.

🧑‍💻  Steps to reproduce

  1. Apply terraform using any version of the module including latest
  2. Wait past the default RDS maintenance window for an automatic upgrade
  3. try and re-apply with any changes such as license/fleet version/etc.

🕯️ More info (optional)

This can be worked around manually with the following in the section of main.tf at https://github.com/fleetdm/fleet/blob/main/terraform/example/main.tf#L86-L94:

  rds_config = {
    engine_version = "8.0.mysql_aurora.3.05.2"
    # See https://fleetdm.com/docs/deploy/reference-architectures#aws for instance classes.
    instance_class = "db.t4g.medium"
    # Prevents edge case render failure in Audit log on the home screen.
    db_parameters = {
      # 8mb up from 262144 (256k) default
      sort_buffer_size = 8388608
    }
  }
rfairburn commented 3 weeks ago

https://github.com/fleetdm/fleet/pull/21585 This is part one of 2. Once this is approved and merged, I will tag the module and update the terraform example to use it.

fleet-release commented 2 weeks ago

Module old as leaves, Upgrade like a blooming spring, Fleet sails on smooth seas.