fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.93k stars 409 forks source link

ADE and VPP sections missing from MDM config page under the Integrations tab when MDM is turned OFF #21716

Closed PezHub closed 1 week ago

PezHub commented 2 weeks ago

Fleet version: 4.56

Web browser and operating system: ANY


💥  Actual behavior

When MDM is turned off, the Fleet UI does not display the ADE or VPP sections on the Integrations -> MDM section

🧑‍💻  Steps to reproduce

  1. Turn off MDM or perform a db-reset
  2. Navigate to Integrations -> mdm section
  3. The MDM for Windows and Mac sections are displayed, but not ADE or VPP per Figma

🕯️ More info (optional)

Missing ADE and VPP sections

georgekarrv commented 2 weeks ago

@noahtalerman @marko-lisica This might be fine (since both of those require MDM to function) I would personally call this working as intended but want to double check w/ Product

ghernandez345 commented 1 week ago

@marko-lisica, wanted to check with you that we discussed this and decided that when mdm was disabled we wanted to not show any of the other sections because they all rely on mdm being enabled? I think I remember we had this chat on zoom and should have updated the dev notes after that. Does this sound correct to you?

cc @noahtalerman @PezHub

marko-lisica commented 1 week ago

@marko-lisica, wanted to check with you that we discussed this and decided that when mdm was disabled we wanted to not show any of the other sections because they all rely on mdm being enabled? I think I remember we had this chat on zoom and should have updated the dev notes after that. Does this sound correct to you?

cc @noahtalerman @PezHub

Hey @ghernandez345 I only remember discussions on what to show for Fleet Free users. Looking at wireframes here, it makes sense to do as specified here.

If Apple MDM isn't enabled then we show card without button and different copy that tells user to enable MDM first.

Also I see there's screen if user navigates directly to ABM or VPP settings.

PezHub commented 1 week ago

QA Notes: Main page looks good Screenshot 2024-09-03 at 10 07 48 AM

navigating directly to /settings/integrations/mdm/abm also shows the correct page Screenshot 2024-09-03 at 10 24 10 AM

QA approved!

fleet-release commented 1 week ago

Config page, silent, With MDM turned off, peace, Now, ADE sings clear.