fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.93k stars 409 forks source link

Wrong error is displayed when uploading an invalid VPP Token #21725

Closed PezHub closed 1 week ago

PezHub commented 2 weeks ago

Fleet version: 4.56

Web browser and operating system: any


💥  Actual behavior

When uploading an invalid VPP token we get a generic error instead of "Invalid token. Please provide a valid content token from Apple Business Manager."

🧑‍💻  Steps to reproduce

  1. Upload an invalid VPP Token (I took my existing one and broke it)
  2. Note the generic error compared to the API response

🕯️ More info (optional)

Wrong Error

🛠️ To fix It should match the one we see when uploading an invalid ABM Token Invalid Token

PezHub commented 1 week ago

QA Notes: Fix looks good! Screenshot 2024-09-03 at 10 41 41 AM

fleet-release commented 1 week ago

Invalid token hides, Clearer message now guides, Ease in steps, it provides.