fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.09k stars 426 forks source link

[QA Wolf] Cannot save settings #21748

Closed qawolf-fleet closed 1 month ago

qawolf-fleet commented 2 months ago

Fleet version: Fleet 0.0.0-SNAPSHOT-4413a20 • Go go1.19.4 (or newer)

Operating system: Linux 64-bit

Web browser: Google Chrome Version 109.0.5414.119 64-bit


🧑‍💻  Expected behavior

💥  Actual behavior

🐞 on Free

Steps to reproduce:

  1. Log in
  2. Navigate to Settings
  3. Click any tab under Settings and Save
  4. Observe Expected: Settings should save Actual: Error: Couldn't update settings: missing or invalid license Video: https://www.loom.com/share/7ec9cf57b3f248f791ba67152745b6a4 (https://www.loom.com/share/7ec9cf57b3f248f791ba67152745b6a4)

Bug report: https://app.qawolf.com/fleet/bug-reports/8b1809fa-3d2b-4dfd-abae-583b764c5243

Affected workflows: • Disable failing policies automation - https://app.qawolf.com/fleet/workflows/clah6bbzh6251466tnpx0mcenwi • Edit organization information - https://app.qawolf.com/fleet/workflows/clah6s2bp6756326tnpky0ibdyu • Edit Fleet web address - https://app.qawolf.com/fleet/workflows/clah6smaa6602416tp6iae6oit2 • Edit host status webhook - https://app.qawolf.com/fleet/workflows/clahafhj010875236tnpcey8tu1l • Edit advanced options - https://app.qawolf.com/fleet/workflows/clahag9md4053976tmity1ablir • Disable software vulnerability automation - https://app.qawolf.com/fleet/workflows/claham7pw10880426tp61wl7ndkp • Disable Script Execution - Free - https://app.qawolf.com/fleet/workflows/clwuzq5da022jjepamh0bw1th

If you are aware of this bug you can set the priority to low which will prevent it from causing a run failure.

More info

xpkoala commented 1 month ago

The error appears to involve the vpp or apple business manager license.

It appears that we were allowing free accounts to add a vpp license in 4.55.0 (not sure if intentional or not). After adding a vpp license to 4.55.0 and upgrading to the 4.56.0 RC I can't get the error to generate and I still can't reproduce this on a fresh instance of the 4.56.0 RC.

I can still add apple MDM to the free instance and not hit any errors like seen here. I'm wondering if this might just be flakiness with the qawolf deploy?

@georgekarrv Would you have any thoughts on what might be causing this?

{
  "message": "Validation Failed",
  "errors": [
    {
      "name": "mdm.apple_business_manager",
      "reason": "missing or invalid license"
    },
    {
      "name": "mdm.volume_purchasing_program",
      "reason": "missing or invalid license"
    }
  ],
  "uuid": "<uuid>"
}
xpkoala commented 1 month ago

This is no longer reproducing on the QAwolf free instance. Closing this out but will monitor to see if it returns.

fleet-release commented 1 month ago

Settings won't save, true, Yet like clouds, bugs shift and move, Fixed, Fleet shines anew.