fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.12k stars 431 forks source link

Support Unicode 9.0.0 in Fleet #21771

Open getvictor opened 2 months ago

getvictor commented 2 months ago

Goal

User story
As a Fleet admin,
I want to use Unicode 9.0.0 (emojis, accents, etc.) in any Fleet string fields
so that I can express myself better.

Context

Now that we don't support MySQL 5.7, we can switch to using the default MySQL 8.0 collation: utf8mb4_0900_ai_ci, which supports Unicode 9.0.0 and is accent-insensitive. The data is still stored in the same format, but sorting and equality operations are updated.

This was discussed in Backend sync: https://us-65885.app.gong.io/call?id=8041045095900447703

Changes

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
lukeheath commented 2 months ago

Thanks for filing! Historically, changing the database collation has been a source of pain during migrations. It works well for us, but there's so much diversity of data across all instances of Fleet that we inevitably end up failing some migrations, which creates a fire drill.

For that reason, I'm inclined to not prioritize this unless this a strong value proposition to justify making a risky collation change.