fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.12k stars 431 forks source link

Add labels to configuration profiles in MSP dashboard #22073

Open noahtalerman opened 2 months ago

noahtalerman commented 2 months ago

Goal

User story
As help desk at a white label MSP,
I want to add labels to my configuration profiles
so that I can control the target of profiles like I can in the Fleet UI.

Objective

None. Not tied to a quarterly objective.

@noahtalerman: Why are we prioritizing it? Because some workflows are blocked for a Fleet customer (see original request)

Original request

Context

Changes

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
xpkoala commented 4 days ago

Small bug found with @eashaw. After selecting and saving custom labels on the MSP dashboard, the changes are saved on the backend, but a refresh is required on the page to see those changes.

A video of the behavior can be seen here https://www.loom.com/share/7db77b6657ba44889eb2f75ea2fcd6c1

eashaw commented 3 days ago

@xpkoala Thank you! I pushed a fix for that issue to the PR.