search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.02k stars 420 forks source link

Ensure software edits (via software install) are tracked appropriately in the host activity feed #22087

Open dherder opened 3 weeks ago

dherder commented 3 weeks ago

Problem

Related to slack thread https://fleetdm.slack.com/archives/C01EZVBHFHU/p1726240975199149

Creating this issue as a placeholder so the feedback does not get lost.

Also related to #20404 @iansltx

@noahtalerman: when software is edited or deleted, we want to preserve all details (software name, scripts results, etc.) for install activities that happened in the past.

noahtalerman commented 3 weeks ago

@iansltx and @dherder I think the key here is that, when software is edited or deleted, we want to preserve all details (software name, scripts results, etc.) for install activities that happened in the past.

I added this to the issue description.

iansltx commented 3 weeks ago

Switching this to a bug as we're going to fast-follow Edit Software with this cleanup on historical data. This is already broken for software deletions (we error out entirely), so tagging with released bug; on Edit we "just" show the wrong data for filename and author because we're pulling it from the software installers table, which is no longer immutable.

iansltx commented 3 weeks ago

Just realized that by looking at existing logs we have enough information to fix install/uninstall links in a future release, because activities include who did them and the software add and edit activities include the then-current package filename. Won’t get content ID but should be a sufficient backfill, and we should be able to get more robustness in 4.58.0 anyway.

getvictor commented 3 weeks ago

This looks like a duplicate of #21654