Cannot add some EXE installers to Fleet

getvictor commented 2 days ago

Fleet version:  4.56.0 Web browser and operating system:

💥 Actual behavior

Could not add YubiKey Manager EXE installer to Fleet

Got error: Couldn't add. Fleet couldn't read the version from yubikey-manager-qt-1.2.6-win32.exe.

🧑‍💻 Steps to reproduce

Try to add the above installers to Fleet.

🕯️ More info (optional)

N/A

🛠️ To fix

The simplest fix is to allow “unknown” version for EXE installers. Full fix is to allow users to specify version.

As a related note, some installer names don't match the program name. For example, Figma's installer name is "Figma Desktop", but when installed it shows up as "Figma". Perhaps we should allow users to specify/edit the name as well.

getvictor commented 2 days ago

Putting this bug on Product board for fix recommendation.

noahtalerman commented 1 day ago

@getvictor can we improve our version extraction to work for YubiKey Manager EXE?

I understand this problem could crop up for other EXEs but I'm wondering if there's a fix we can make here for YubiKey.

noahtalerman commented 1 day ago

Figma's installer name is "Figma Desktop", but when installed it shows up as "Figma"

@getvictor we want the software title for the EXE (installer) to be matched w/ the software title for the installed Figma.

Why? When the IT admin visits the software title page they see the EXE, it's version, and all the versions of Figma installed across their Fleet. This way, they can easily see what hosts have the package installed and which hosts have a different version (via osquery).

How could we do that for Figma?

getvictor commented 1 day ago

@noahtalerman it'll take some time to investigate the options. Can you assign to me and put it on our board with appropriate priority?

noahtalerman commented 1 day ago

it'll take some time to investigate the options. Can you assign to me and put it on our board with appropriate priority?

Done FYI @sharon-fdm

fleetdm / fleet