search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.94k stars 409 forks source link

[QA Wolf] Searching for existing policy shows no results #22184

Open qawolf-fleet opened 4 days ago

qawolf-fleet commented 4 days ago

Fleet version: Fleet 0.0.0-SNAPSHOT-4413a20 • Go go1.19.4 (or newer)

Operating system: Linux 64-bit

Web browser: Google Chrome Version 109.0.5414.119 64-bit

🧑‍💻  Expected behavior

💥  Actual behavior

🐞 on Premium

Steps to reproduce:

  1. Login
  2. Navigate to the policies page and add a new policy, in this instance we chose, Operating system up to date (macOS) and named it Mac OS Query220
  3. Navigate to the hosts tab and back to the policy page
  4. Search for our policy name Expected: Our policy should show in the results Actual: No matching policies shown

Timestamp: 0:50 Video: https://www.loom.com/share/7c7a217766304f00bd45c7d782cbe4a3 (https://www.loom.com/share/7c7a217766304f00bd45c7d782cbe4a3)

Bug report: https://app.qawolf.com/fleet/bug-reports/1940cfd0-46df-4967-83db-cf9245399fb2

Affected workflows: • Global Maintainer able to create an OS Specific policy - https://app.qawolf.com/fleet/workflows/clainljer09436tmioqsgtgoc

If you are aware of this bug you can set the priority to low which will prevent it from causing a run failure.

More info

getvictor commented 3 days ago

I can't reproduce this. In the video, I see the Policy screen switches from No teams to All teams, which is why the policy cannot be found (it was created under No teams).

getvictor commented 3 days ago

When searching for policies under All teams, you should not see team-specific policies. cc: @noahtalerman

noahtalerman commented 3 days ago

Hey @getvictor! Pinging @rachaelshaw here for help.

Rachael, this sounds like it might be related to recent work we did to bring all policies (across teams) to "All teams" view.

Rachael, when you get the chance can you please help Victor get to the bottom of the expected behavior? Thanks :)

rachaelshaw commented 3 days ago

@noahtalerman The "All teams" view still only shows global policies, we never made any changes to show all team-level policies there. (We did the opposite: team-level policy views include global policies.) @getvictor is right, in the video they made a policy that runs on "No team" hosts and tried to search for it under "All teams", which wouldn't work. (Maybe there's an update we could make to the "All teams" language to clarify that these are global policies, not a list of all the team-level policies, if that isn't clear to users.)

noahtalerman commented 2 days ago

@rachaelshaw ah, I see. So this is the expected behavior and not a bug.

I think that's what @getvictor was saying here (I read it too fast)

If that's right I think we can close this one. @rachaelshaw I think up to you if you think it's worth filing a small story to clarify.

cc @sharon-fdm