fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.11k stars 427 forks source link

No team gitops unreleased bugs #22185

Closed getvictor closed 1 month ago

getvictor commented 1 month ago
  1. Newlines missing
❯ ../fleet/build/fleetctl gitops -f teams/no-team.yml --dry-run
[!] 'agent_options' is not supported for "No team". This key will be ignored.[!] 'queries' is not supported for "No team". This key will be ignored.Error: 1 error occurred:
    * cannot set 'team_settings' on 'No team' file: "teams/no-team.yml"
  1. No Team gitops deleting All Teams queries
❯ ../fleet/build/fleetctl gitops -f teams/no-team.yml
[!] 'agent_options' is not supported for "No team". This key will be ignored.[!] 'queries' is not supported for "No team". This key will be ignored.[!] 'agent_options' is not supported for "No team". This key will be ignored.[!] 'queries' is not supported for "No team". This key will be ignored.[+] applying 2 software packages for 'No team'
[+] applied 'No Team' software packages
[+] syncing 9 policies
[+] synced 9 policies
[-] deleting policy Policy windows
[-] deleting policy Policy linux
[-] deleting 2 policies
[-] deleted 2 policies
[-] deleting query Scheduled query stats
[-] deleting query orbit_info
[-] deleting query Collect fleetd update channels
[-] deleting query osquery_info
[-] deleting 4 queries
[-] deleted 4 queries
[!] gitops succeeded
  1. Empty apple_bm_default_team errors when running global config and no-team.yml
    ❯ ../fleet/build/fleetctl gitops -f default.yml -f teams/no-team.yml --dry-run
    [!] 'agent_options' is not supported for "No team". This key will be ignored.[!] 'queries' is not supported for "No team". This key will be ignored.[+] would've applied fleet config
    [+] would've applied enroll secrets
    [+] syncing 3 policies
    [+] syncing 4 queries
    [!] 'agent_options' is not supported for "No team". This key will be ignored.[!] 'queries' is not supported for "No team". This key will be ignored.[+] applying 2 software packages for 'No team'
    [+] would've applied 'No Team' software packages
    [+] syncing 9 policies
    Error: apple_bm_default_team  not found in team configs

default.yml has mdm section:

  mdm:
    apple_bm_default_team: ""
    end_user_authentication:
      entity_id: ""
      idp_name: ""
      issuer_uri: ""
      metadata: ""
      metadata_url: ""
  1. "" instead of "software" in error message when top level software key is bad.
    Error: 1 error occurred:
    * Couldn't edit software. "" must be a spec.Software, found array
getvictor commented 1 month ago

QA Done!

fleet-release commented 1 month ago

Gitops issue fixed, Flowing like a quiet stream, Fleet's path now untrixed.

Errors once were lost, Now found in crystal syntax, No team's heavy cost.

Queries once deleted, Now safely nested in clouds, Team's trust, reinstated.

Empty keys now filled, In the glass city's logic, Fleet's promise, fulfilled.