fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.15k stars 432 forks source link

Fully support user-scoped install scripts on Windows #22200

Open getvictor opened 2 months ago

getvictor commented 2 months ago

Goal

User story
As a Fleet admin,
I want to install a Windows user-scoped program reliably
without waiting for the user to be logged in.

Context

Some Windows programs can only be installed in user-scope, such as Figma.

As covered in #20000, the downside of our example user-scoped install script is that the end user must be logged in. That means if the user turns on their laptop, but doesn't log in for a few minutes, Fleet may attempt a user-scoped install/uninstall and will fail. We can attempt to solve this issue by having Fleet or fleetd check if the user is logged in before running the script.

Another issue with the user-scoped script is that it lacks debug information since the script runs as a separate process. We should gather the logs from the user process and report them back to Fleet.

Changes

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
noahtalerman commented 1 month ago

Hey @getvictor I pulled this request off of feature fest b/c it doesn't meet the criteria for prioritization: https://github.com/fleetdm/fleet/pull/23184/files#diff-c99d12c3af50c0c2aca2b9ef7597c02ccfe87678291956ff0b2e83d63978ea38R370

We might address this in some fashion when we get to Fleet-maintained apps for Windows. FYI @marko-lisica