Closed iansltx closed 3 weeks ago
I removed the ~unreleased per my understanding it's not going to 4.57.0
For context and clarity, this would be undoing changes implemented this sprint:
Recent spec explicitly calling for allowing both options at all times unless SW is "pending": https://www.figma.com/design/ToQaK2yUJwDyzagTdrbOfX/%2320320-Uninstall-packages?node-id=5364-13355&m=dev
Product confirmed this approach after discussion:
And so this ticket was made to explicitly track those updates: https://github.com/fleetdm/fleet/issues/21931
+1 Jacob, thanks for outlining.
Staying flexible about this missed edge case and built out this bug fix since it's best for the ux to not be able to click an action that we 100% know won't work (reusing tooltip/behavior from general host action dropdown --enable-scripts disabled tooltip/behavior).
In cloud city's glow, Fleet's code evolves, scripts align. No false paths to sow.
💥 Actual behavior
For example, uninstalling a package is allowed when scripts aren't enabled on the host (or the host is osquery rather than fleetd). This behavior is inconsistent with running scripts, which does disable when scripts aren't runnable on the host.
Technically the example I'm providing here is an unreleased bug, but we're going with a smaller patch that makes error messaging more visible for this release, and can follow on with better UX.
🧑💻 Steps to reproduce
🕯️ More info (optional)
To fix
If scripts are disabled for a host, disable the options that require scripts and show a tooltip like we do for Actions > Run script on the Host details page (Figma here)