fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
2.94k stars 409 forks source link

Manually review migrations for 4.57.0 #22248

Open georgekarrv opened 1 day ago

georgekarrv commented 1 day ago

Before Releasing 4.57.0 review the migrations introduced and flag any potentially time intensive migrations.

iansltx commented 1 day ago

This won't show up in DB migrations, but as part of this release we have a cron to go through all installers and pull them out of DB or object storage to confirm bundle IDs for uninstallers. This is not part of migrations but is a backfill job that we'll want to watch for cloud customers with installers, and mention in release notes (/cc @spokanemac) in general.

iansltx commented 1 day ago

Here are the DB migrations new to this release, which I'll be reviewing: 4.56-to-4.57-migrations.txt

iansltx commented 1 day ago

Actually, that diff provides false positives due to cherry-picks. Going to take a different approach: migrating from scratch to v4.56.0, then migrating to 4.57.0, and getting the list that way.

iansltx commented 1 day ago

Here are the actual migrations:

Policy Automatic Install Software Add Auto Increment Column To Profiles Add URL To Software Installers Uninstall Packages Add Policies To No Team

AKA

Erring on the side of caution, we heed largest-record counts for the following tables:

If none of those numbers are abnormally large, should be good to go.