fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.05k stars 423 forks source link

Edit labels for custom settings after upload #22332

Open ddribeiro opened 3 weeks ago

ddribeiro commented 3 weeks ago

Goals

Gong snippet: https://us-65885.app.gong.io/call?id=5280718531025988317&highlights=%5B%7B%22type%22%3A%22SHARE%22%2C%22from%22%3A467%2C%22to%22%3A520%7D%5D

Problem

As a Fleet admin, I can create labels and use them with custom settings to target specific hosts. After a custom setting is created, I can’t add new labels or remove existing ones from that custom setting.

What have you tried?

I could remove an existing custom setting and add it again to change the labels in the target section. This is not ideal as it could remove the profiles from my hosts and create a gap in management while I add it again.

Removing certain profiles with certificates or Wi-Fi payloads could also cause an interruption in network connectivity and prevent the host from being able to receive new profiles.

Potential solutions

Fleet should add the ability to edit existing custom settings to update the labels associated with it.

What is the expected workflow as a result of your proposal?

A Fleet admin would be able to target custom settings specific hosts using labels. If they would like to add or remove labels from that custom setting in the future, they would be able to edit the existing custom setting and update its labels. They would not need to delete the custom setting and upload it again to update the labels.
ddribeiro commented 3 weeks ago

Similar to #20404.

noahtalerman commented 2 weeks ago

@ddribeiro I think editing labels is possible in the GitOps workflow (aka Fleet's YAML files). Is the customer using the GitOps workflow? If so, did they try to edit labels for a profile?