fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.12k stars 431 forks source link

Query > Live query > Improve finding and selecting teams/labels #22448

Open noahtalerman opened 1 month ago

noahtalerman commented 1 month ago

Goal

User story
As a Fleet user who has 100 teams and/or labels or 2 teams and 10 labels,
I want to quickly find a team or label when running a live query
so that I don't have to use CMD+F to find the team.

Objective

Customer promises + renewal requests

Original request

Context

Changes

Adds the ability to search within Teams and Labels sections. Includes adding expand/collapse functionality when lists of Teams/Labels get long.

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
noahtalerman commented 1 month ago

Hey @zayhanlon we spun this user story off of this request and brought the story into the design sprint.

@randy-fleet I passed this story to you since you have some extra capacity 🚀

noahtalerman commented 1 month ago

Hey @zayhanlon heads up, this user story didn't make it into the upcoming engineering because we didn't get it estimated in time.

It's still prioritized. We left it on the drafting board so that it can be pulled into the next engineering sprint.

RachelElysia commented 1 month ago

@rachaelshaw : we can always change from rows to number of teams or labels if it's too difficult to calculate where to truncate

RachelElysia commented 1 month ago

@iansltx : UX - If something is selected, maybe it should always show it, so it doesn't hide, similar to select target input

e.g. if you are selecting 6 labels, it's hard to see which ones are selected if the UI is hiding them

We want to bring this idea back to the next endpoint ops design meeting <3

RachelElysia commented 1 month ago

@iansltx : We also don't need a loading state for search because it's client side

RachelElysia commented 1 month ago

Moved back to ready to spec because we want more design review on this

@jacobshandling current ballpark 8-13

noahtalerman commented 1 month ago

Hey @RachelElysia thanks for the detailed notes! B/c @randy-fleet is the Product Designer for this story, I added you to Randy's design review today so we can decide on a path forward.

cc @rachaelshaw

RachelElysia commented 1 month ago

@noahtalerman perfect thanks!

randy-fleet commented 1 month ago

@RachelElysia I've made the updates in Figma that we discussed.

RachelElysia commented 1 month ago

@randy-fleet Thanks for taking the team's feedback and turning it around so fast! Feel free to move it to the correct column for our team's estimation call next Wednesday.

noahtalerman commented 4 weeks ago

Thanks @randy-fleet!

Can you please bring this one to design review today?

We can take a pass through changes/dev notes live.

cc @RachelElysia

noahtalerman commented 3 weeks ago

Hey @sharon-fdm heads up that this user story is ready for specs.

Just a reminder that during last week's estimation, we decided to bring this one back to design review (see comment [here](Moved back to ready to spec because we want more design review on this)). It's now ready for specs again.

cc @RachelElysia

noahtalerman commented 3 weeks ago

Hey @sharon-fdm it looks like we missed this one during estimation yesterday.

Can we please estimate it before we kick off the next sprint?

sharon-fdm commented 3 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @jacobshandling @RachelElysia