fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.16k stars 432 forks source link

Move lock/wipe scripts and MDM commands to `ee/` folder #22544

Open noahtalerman opened 1 month ago

noahtalerman commented 1 month ago

Goal

User story
As a Fleet Premium user,
I want the Windows and Linux lock/wipe scripts to live under Fleet ee/ folder
so that I can be confident what I see on fleetdm.com/pricing (free v. paid) is in line with Fleet's license.

Objective

Not tied to a quarterly objective. Why are we doing it? Because the product is inconsistent w/ the pricing page.

Context

Windows and Linux lock/wipe scripts current live here: https://github.com/fleetdm/fleet/tree/main/scripts/mdm

Lock/wipe is included in Fleet Premium. From fleetdm.com/pricing: Screenshot 2024-10-01 at 10 33 48 AM

Changes

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
noahtalerman commented 1 month ago

Hey @georgekarrv I moved this story to ready for specs. It's a cleanup story.

Just to make sure, before we move the scripts, does the Fleet product even use the lock/wipe scripts in this folder? https://github.com/fleetdm/fleet/tree/main/scripts/mdm

Meaning when I click the Lock button on a Linux host in the UI, do we use the scripts here? If not, maybe there is another spot in the code that we want to move to ee/

The reason I ask is because it looks like we haven't made any changes to those scripts for 3 months but I thought we made some updates to Linux lock recently (I could be misremembering)

georgekarrv commented 1 month ago

@noahtalerman while the UI for windows lock and wipe are premium we have had the scripts be part of the free tier. Has that changed?

noahtalerman commented 1 month ago

@georgekarrv scripts are free but we want all parts of the lock/wipe features to be premium (UI, API, CLI, scripts, etc.). Similar to how policies are free but CIS Benchmarks (powered by policies) are premium.

Like the policies for CIS Benchmarks, we want the scripts for Window and Linux lock/wipe to live under ee/.

Now that I'm thinking about it, I think this means we also move the MDM command (XML) for macOS, iOS, and iPadOS to ee/. I updated the issue description to reflect this.

noahtalerman commented 1 month ago

Hey @georgekarrv looks like this one didn't get estimated this week. Anything I can do to help move it forward?

noahtalerman commented 1 month ago

Hey @georgekarrv just giving you another ping! Please check out my comment here and let me know if there's anything I can do to help move this one forward.

georgekarrv commented 1 month ago

Yup, none needed thanks we just missed estimating this one last week

georgekarrv commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @dantecatalfamo @getvictor @ghernandez345 @gillespi314 @jahzielv @mna