Closed noahtalerman closed 1 week ago
Reminder to consider reducing the currently = 3 parallel downloaders in Fleet for GitOps: https://github.com/fleetdm/fleet/blob/f9c0b2444b860015cc2af1f5ca614d8d74253202/ee/server/service/software_installers.go#L1289
Just worried about Fleet OOM (Out of Memory) crashes.
QA Notes:
the majority of testing and results are documented with ticket #20308
But here are the gitops results for the bump in size limit.
/fleetdm/fleet rc-minor-fleet-v4.58.0 ⇡2 ❯ ./build/fleetctl gitops -f ~/fleetdm/gitops_configs/softwareinstall.yaml
[+] applying MDM profiles for team Ninjas
[+] applying 2 software packages for team Ninjas
[+] applied 1 teams
[!] gitops succeeded
~/f/fleet rc-minor-fleet-v4.58.0 ⇡2 ❯ ./build/fleetctl gitops -f ~/fleetdm/gitops_configs/softwareinstall.yaml
[+] applying MDM profiles for team Ninjas
[+] applying 2 software packages for team Ninjas
Error: applying software installers for team "Ninjas": validation failed: software.url Couldn't edit software. URL ("https://swcdn.apple.com/content/downloads/05/02/062-78643-A_T7YK72IEUB/f6jf452yv3xah9gljv28yxjs5x5bm7p1fr/InstallAssistant.pkg"). The maximum file size is 3 GB
Larger files now flow, Like rivers through glass city, Creativity grows.
💥 Actual behavior
Current file size limit is 500MB.
As part of this story (targeted for 4.58) we planned to bump the limit to 3GB.
This allows users to add larger packages like Adobe Create Cloud (see separate request here)
🛠️ To fix
Bump file size limit to 3GB. Figma wireframes w/ updated error message is here.