fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.09k stars 427 forks source link

Grouped policy failure display #22920

Open iansltx opened 2 weeks ago

iansltx commented 2 weeks ago

noahtalerman commented 1 week ago

Goal

User story
As an administrator,
I want to see actions taken for the same policy grouped rather than one per host
so that I can easily scan the activity feed for distinct types of events.

Objective

TODO /cc @spokanemac

Context

What else should contributors keep in mind when working on this change?

This could be handled to some extent front-end-only with no API changes, but activity grouping may be a powerful primitive for customers with larger host counts, particularly for patching flows that will consistently fail existing hosts as new versions of a software package are rolled out. So an initial revision of this might be FE-only, with a new grouped activities endpoint (or query parameter) as a follow-on.

Changes

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Create a policy automation for an install or script run
  2. Fail that policy across a bunch of hosts, causing the automation to run
  3. Look at the global activity feed and confirm that activities are grouped, with hosts visible if you drill down.

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
noahtalerman commented 1 week ago

Hey @iansltx thanks for tracking this one. We're setting it to the side b/c it doesn't meet the criteria for prioritizing a feature: https://github.com/fleetdm/fleet/pull/23184/files#diff-c99d12c3af50c0c2aca2b9ef7597c02ccfe87678291956ff0b2e83d63978ea38R370

I'm guessing this one is a little bit too large to call a small UX improvement.

noahtalerman commented 1 week ago

@iansltx: My bet is that this will come up as a customer pain point as soon as we have larger fleets of machines using policies to keep software patched, so this is really a question of whether we build before the pain we know customers will see, or after.

Noah: Make sense! I think let’s dogfood it first. Feel the pain ourselves. That way, we can come up w/ the best solution.

@lukeheath heads up that it looks like this request got the ~dogfood label but I don't think we're dogfooding the feature: automatically install software (via policy automation) yet.

It would be great to dogfood that feature! Removing the ~dogfood label for now.