search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.16k stars 432 forks source link

"Disabled" forms accessible via tabbing & editable #22985

Open rachaelshaw opened 1 month ago

rachaelshaw commented 1 month ago

Fleet version: 4.57.0

Web browser and operating system: Chrome 129.0.6668.101 running on macOS

💥  Actual behavior

In manage automations modals, turning a toggle off makes the form below look disabled, but you can still tab in & edit.

Screenshot 2024-10-16 at 12 30 15 PM

🧑‍💻  Steps to reproduce

  1. Go to Policies > Manage automations > Calendar events or Policies > Manage automations > Other workflows
  2. Click the toggle to turn automations off
  3. Press tab and tab through the form; try to edit the fields

🕯️ More info (optional)

"End user migration workflow" on /settings/integrations/mdm has the same UI pattern with fields truly disabled; manage automations modals should work like this form.

Fix any place that has a disabled form via a slider that can still be reached through the keyboard to not be reachable by the keyboard when disabled

RachelElysia commented 1 month ago

Please add your planning poker estimate with Zenhub @jacobshandling

RachelElysia commented 1 month ago

IIRC there's just some kind of styling overlay, and so we need to add is disabled states to all form fields (radio, dropdown, inputs, checkbox, dropdown, etc)

xpkoala commented 6 days ago

@RachelElysia There is a slight aberration in the Policies > Other workflows modal flow.

With other workflows disabled and the destination url empty I am unable to save the state. A red box appears around the destination url box signifying that a url must be present. This should not be required when the feature is disabled.

A quick video of the behavior is attached. This only appears to be occurring in the Other workflows view.

https://github.com/user-attachments/assets/4b9396d0-3539-48b5-9e2d-239157b5630d

RachelElysia commented 5 days ago

@xpkoala - Nice find! I think this, not being able to disable the automations when webhook is selected with an empty field) is a separate released bug

@sharon-fdm should we make another ticket or just pass this on top of my 4.61 plate?

sharon-fdm commented 5 days ago

@RachelElysia, if that's a 1-2 points, just fix as part of this ticket. otherwise create a new one.