search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.06k stars 425 forks source link

Confirmation checkbox before deleting a host is missing #23092

Open allenhouchins opened 1 day ago

allenhouchins commented 1 day ago

Fleet version: 4.58.0

Web browser and operating system: Chrome or Safari

💥  Actual behavior

There was previously a confirmation checkbox presented before an admin could delete a host. This still exists on the Lock action. I would expect to see a confirmation before taking such a destructive action.

Screenshot 2024-10-22 at 12 54 34 PM Screenshot 2024-10-22 at 12 54 44 PM

🧑‍💻  Steps to reproduce

  1. Go to a Host record > Actions > Delete

🕯️ More info (optional)

N/A

lucasmrod commented 14 hours ago

I don't remember having a confirmation checkbox for deleting a host. (I might have missed it.)

That said, there is one for Wiping a host: Screenshot 2024-10-23 at 12 04 44 PM

lucasmrod commented 14 hours ago

Deleting a host just deletes it from Fleet (it is not a destructive action). And on macOS/Windows/Linux the agent will re-enroll afterwards.

RachelElysia commented 10 hours ago

Same, IIRC there's never been a please check to confirm for deletion