fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.16k stars 432 forks source link

Add pagination to automations modal on Policies and disable “Manage automations” when not available #23243

Open noahtalerman opened 1 month ago

noahtalerman commented 1 month ago

Goal

User story
As an IT admin,
I want to see an instruction tooltip on "Manage automation" explaining when policy and vulnerability automation can be set
so that I know what to expect.

Key result

Every sprint, ship small UX improvements based on dogfooding or customer feedback.

Original requests

Context

Changes

Product

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.
xpkoala commented 4 weeks ago

@marko-lisica The current work in progress design for the tooltip states, To use automations, add policy to a team or “No team” first.

This does not take into consideration the case presented in https://github.com/fleetdm/fleet/issues/23047 where team policies do exist, but a large number of inherited policies are crowding the first page.

We might consider different text to include this confusing state.

marko-lisica commented 4 weeks ago

Thanks @xpkoala! I'll consider this and try to improve the copy to include this.

rachaelshaw commented 4 weeks ago

@marko-lisica @noahtalerman should we incorporate https://github.com/fleetdm/fleet/issues/23229 into this design?

noahtalerman commented 4 weeks ago

@marko-lisica looks like the bug (#23229) addresses the same problem? I assigned you to the bug to check that out.

If it's addresses the same problem I think we can close the bug and point to this story instead.

cc @nonpunctual @rachaelshaw

marko-lisica commented 3 weeks ago

@noahtalerman @rachaelshaw I don't think this bug addresses #23229. Seems that in #23229 it's expected to have vulnerability automation (on Software page) for each team not only for All hosts. To me it even sounds like a feature request, since that's how it's designed I believe.

noahtalerman commented 3 weeks ago

Seems that in https://github.com/fleetdm/fleet/issues/23229 it's expected to have vulnerability automation (on Software page) for each team not only for All hosts. To me it even sounds like a feature request, since that's how it's designed I believe.

@marko-lisica good catch. That's right.

However, is there a solution we can use on Software page and Policies page? Does it make sense UX-wise to show a disabled Manage automations button on the Software page when filtering by a team?

marko-lisica commented 3 weeks ago

@noahtalerman I think it does make sense. It's similar patter. We keep the button in the same place but disable when not available + explain why. I think it would help to prevent confusion especially for new users.

noahtalerman commented 3 weeks ago

I think it's worth adding selection count when jumping through pages. That's what we do for setup experience software selection here.

Screenshot 2024-11-01 at 2 42 49 PM

Hey @marko-lisica, I’m still not sure how it’s supposed to work if you select some policies (or software), click Save, come back, select some more software, and then clear selection.

Doe that clear the policies I saved?

marko-lisica commented 3 weeks ago

@noahtalerman When I think better it's probably better to cut "Clear selection" functionality and keep only count of selected policies across all pages. I just updated Figma to reflect that. Wdyt?

marko-lisica commented 3 weeks ago

Hey @georgekarrv, heads up, this story is ready to spec.

noahtalerman commented 2 weeks ago

@georgekarrv just giving you another ping! this story is ready to spec.

georgekarrv commented 2 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @ghernandez345 @gillespi314

RachelElysia commented 2 weeks ago

Ran into this again where I thought it was a bug that the manage automations modal disappeared switching to team view. Had to confirm via the code before I remember that it was hidden if there were no team policies on the page.