Introduce new variant to "Text-icon" button

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)

https://fleetdm.com

Other

3.17k stars 434 forks source link

Introduce new variant to "Text-icon" button #23411

Open randy-fleet opened 1 month ago

randy-fleet commented 1 month ago

💥 Actual behavior

In order to simplify our design system and increase consistency, we've created a new variant to the "Text-icon" button that includes a background. This will replace the need for the custom "pagination button" and "back link" components, allowing them to be deprecated. Please reference Figma for guidance, and ensure Storybook and product is updated.

🕯️ More info (optional)

N/A

RachelElysia commented 1 month ago

My estimate bold is 3 but leaning up to a 5 All back link and pagination needs to be refactored throughout the UI.

BackLink.tsx currently uses Link component instead of a Button and will need to be refactored and tested
Pagination.jsx is still javascript class component and needs to be refactored to typescript functional component to match updated patterns
There's some pagination in the UI that doesn't use these components (e.g. one I can think of is the activity feed) and also needs to be updated

jacobshandling commented 1 month ago

Please add your planning poker estimate with Zenhub @RachelElysia

jacobshandling commented 1 month ago

8 - lots of inconsistencies around these components and instances in many places of the app that will all need to be brought into consistency / alignment with this new abstraction