Remove unused button variants from Storybook

[randy-fleet]

💥  Actual behavior

In order to simplify our design system and increase consistency, we've worked to reduce the number of button variants we have. We want to make sure Storybook is consistent with our Figma Design System as well. Please reference Figma for guidance on variants, and ensure Storybook and product is updated.

🕯️ More info (optional)

N/A

[RachelElysia]

My estimate: 3, this is far reaching since all button stylings will need to be looked at for modification.

Current variants:

export type ButtonVariant =
  | "brand"
  | "success"
  | "alert"
  | "blue-green"
  | "grey"
  | "warning"
  | "link"
  | "label"
  | "text-link" // Underlines on hover
  | "text-icon"
  | "icon" // Buttons without text
  | "small-icon" // Buttons without text
  | "inverse"
  | "inverse-alert"
  | "block"
  | "unstyled"
  | "unstyled-modal-query"
  | "contextual-nav-item"
  | "small-text-icon"
  | "oversized";

@randy-fleet we have several buttons in the UI that aren't outlined on the Figma you attached, one example of the top of my head is icon buttons, another that is said to be deprecated but is all over the UI is inverse buttons. Whomever takes this ticket will need to work with you to ensure the style guide includes plans for all UI components already in use.

[jacobshandling]

Please add your planning poker estimate with Zenhub @RachelElysia

[jacobshandling]

Estimate 5 - broad changes like this always uncover lots opportunities for code cleanup and abstraction improvement