Open iansltx opened 3 weeks ago
Please add your planning poker estimate with Zenhub @jacobshandling
Add quick test if time allows
I just tested this manually, maintainers have access to the API for install software and run script but not for calendar events and other workflows (errors: [{name: "base", reason: "forbidden"}]
.
I'm thinking for maintainers, we should show to the dropdown but disable calendar events and other workflows with a tooltip OR we should remove calendar events and other workflows from the dropdown.
wdyt? @rachaelshaw / @noahtalerman
Visual of admin dropdown and what works for maintainers and what doesnt:
Adding this to my plate since I think we should get this into 4.60 major release as we are preventing major flows for maintainers in the UI that are available in the API.
Here's the permissions we have documented, looks like this doesn't quite match up with what @RachelElysia found (says maintainers can manage calendar events):
@rachaelshaw Calendar events permissions mismatch is covered in #23483. The issue there is that the current modal covers both things that a maintainer is allowed to do (toggling per policy) and things that require an admin (setting the web hook and turning on/off calendar integrations entirely).
Check other workflows APIs if maintainer has access to either of them
@rachaelshaw decide if we should try to fix in 4.60
related to #23483
@RachelElysia & @rachaelshaw
Per our discussion, I've created the following two wireframes:
LMK what you think. I'm also not sure of the process on how to move tickets along. I'm assuming this ticket should not move until we've all approved the above, after which I'll move these sections to the "Ready" page?
Fleet version: 4.57.0+ (installs), 4.58.0+ (scripts)
💥 Actual behavior
Per @RachelElysia's comment, maintainers can't set policy automations for software installs or script runs in the UI, though they can in the API. Per today's design review outcome, the API permission is the reasonable one here, so we should match that in the UI.
🧑💻 Steps to reproduce
🛠️ To fix
Show the policy automation drop-down in team-specific view, containing script and install automation options, for Maintainers, subject to the gating we do by license type.