Add Script Editor To Scripts View in Fleet UI

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)

https://fleetdm.com

Other

3.12k stars 431 forks source link

Add Script Editor To Scripts View in Fleet UI #23767

Open nonpunctual opened 4 days ago

nonpunctual commented 4 days ago

customer-flacourtia:
- Gong snippet: https://us-65885.app.gong.io/call?id=8250884210103291952&highlights=%5B%7B%22type%22%3A%22SHARE%22%2C%22from%22%3A1702%2C%22to%22%3A1741%7D%5D
- Slack thread: https://fleetdm.slack.com/archives/C064WRT4F54/p1731510447893639

RachelElysia commented 4 days ago

@nonpunctual Probably some kind of iteration to the designs in #22446 which allowed you to view, but add the ability to edit and click save.

nonpunctual commented 4 days ago

https://github.com/fleetdm/fleet/issues/19925#issuecomment-2374475068 https://github.com/fleetdm/fleet/issues/19582 https://github.com/fleetdm/fleet/issues/22452

From discussion:

I will say I think just viewing the script READ ONLY in a colorized script editor is safer to build.

Sometimes the query parser is wrong & that would happen even more with scripts because shell script syntax is looser so the parser would have to be less opinionated, ie, more potential uncaught errors

But, that said, whatever Jamf has is just some lib for text editing with some bells & whistles (ike VSCode or Sublime Text) in the web view

noahtalerman commented 3 days ago

Creating new issue from https://github.com/fleetdm/fleet/issues/19925#issuecomment-2374475068 per @zayhanlon

Scripts can be uploaded to Fleet UI
- Scripts can't be viewed or edited in Fleet UI
- In order to view a script that's been uploaded to Fleet the file has to be downloaded & viewed locally
Fleet has a shell-like text editor for SQL queries
- It is convenient to make changes to a script in a tool like Fleet during testing or workflow updates
- It can also be a quick way to validate GitOps workflows to see the current version of a script in the UI
- The extra download step is an inconvenience

This issue is related to: https://github.com/fleetdm/fleet/issues/17993

This FR contributes to product maturity / MDM feature parity.

noahtalerman commented 3 days ago

@zayhanlon can you please add the Gong snippet for this request?

zayhanlon commented 3 days ago

@noahtalerman yes we can! this one came up on slack - https://fleetdm.slack.com/archives/C064WRT4F54/p1731510447893639 but we can bring it up on the call next week @pintomi1989 fyi

nonpunctual commented 3 days ago

@noahtalerman @zayhanlon @pintomi1989 added gong snippet