search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.15k stars 432 forks source link

to RC: Linux disk encryption: frontend changes, backend missing private key … #23983

Closed jacobshandling closed 1 day ago

jacobshandling commented 1 day ago

This PR already merged to main, see https://github.com/fleetdm/fleet/pull/23714. This is against the release branch so it can be included in 4.60.0.

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 52.70270% with 70 lines in your changes missing coverage. Please review.

Please upload report for BASE (rc-minor-fleet-v4.60.0@319b15a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ngsModal/OSSettingsTable/OSSettingsTableConfig.tsx 6.66% 14 Missing :warning:
frontend/services/entities/disk_encryption.ts 6.66% 14 Missing :warning:
...es/hosts/details/DeviceUserPage/DeviceUserPage.tsx 33.33% 10 Missing :warning:
...es/hosts/details/cards/HostSummary/HostSummary.tsx 65.38% 9 Missing :warning:
ee/server/service/teams.go 0.00% 5 Missing and 3 partials :warning:
...erPage/CreateLinuxKeyModal/CreateLinuxKeyModal.tsx 33.33% 4 Missing :warning:
frontend/interfaces/mdm.ts 33.33% 2 Missing :warning:
frontend/pages/hosts/details/helpers.ts 60.00% 2 Missing :warning:
frontend/utilities/endpoints.ts 0.00% 2 Missing :warning:
frontend/interfaces/platform.ts 94.11% 1 Missing :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## rc-minor-fleet-v4.60.0 #23983 +/- ## ========================================================= Coverage ? 63.16% ========================================================= Files ? 1563 Lines ? 148805 Branches ? 3766 ========================================================= Hits ? 93996 Misses ? 47391 Partials ? 7418 ``` | [Flag](https://app.codecov.io/gh/fleetdm/fleet/pull/23983/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/fleetdm/fleet/pull/23983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | `64.02% <57.89%> (?)` | | | [frontend](https://app.codecov.io/gh/fleetdm/fleet/pull/23983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | `52.55% <51.93%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: