fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.16k stars 432 forks source link

UI - fix a small issue in the device user page banner logic, add test #24001

Closed jacobshandling closed 3 days ago

jacobshandling commented 4 days ago

Bug:

Screenshot 2024-11-20 at 4 43 19 PM

Fixed:

Screenshot 2024-11-20 at 4 44 48 PM
codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.47%. Comparing base (70d01d9) to head (6b17cd6). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #24001 +/- ## ======================================= Coverage 63.47% 63.47% ======================================= Files 1576 1576 Lines 149666 149666 Branches 3818 3818 ======================================= + Hits 94995 94997 +2 + Misses 47098 47095 -3 - Partials 7573 7574 +1 ``` | [Flag](https://app.codecov.io/gh/fleetdm/fleet/pull/24001/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | Coverage Δ | | |---|---|---| | [frontend](https://app.codecov.io/gh/fleetdm/fleet/pull/24001/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | `52.58% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: