fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.15k stars 432 forks source link

to RC: UI - fix a small issue in the device user page banner logic, add test… #24020

Closed jacobshandling closed 12 hours ago

jacobshandling commented 12 hours ago

This PR already merged to main, see https://github.com/fleetdm/fleet/pull/24001. This is against the release branch so it can be included in 4.60.0.

codecov[bot] commented 12 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (rc-minor-fleet-v4.60.0@3003f04). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## rc-minor-fleet-v4.60.0 #24020 +/- ## ========================================================= Coverage ? 63.13% ========================================================= Files ? 1561 Lines ? 148134 Branches ? 3818 ========================================================= Hits ? 93529 Misses ? 47213 Partials ? 7392 ``` | [Flag](https://app.codecov.io/gh/fleetdm/fleet/pull/24020/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | Coverage Δ | | |---|---|---| | [frontend](https://app.codecov.io/gh/fleetdm/fleet/pull/24020/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | `52.54% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

iansltx commented 12 hours ago

@jacobshandling if you want that extra commit to stick around please PR it into main as well