fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.15k stars 432 forks source link

Fix Orbit version check in LUKS escrow trigger endpoint #24026

Closed iansltx closed 12 hours ago

iansltx commented 12 hours ago

The host context never includes Orbit version (only the hosts/{id} endpoint does) so we need to grab that data when we need it.

Checklist for submitter

codecov[bot] commented 11 hours ago

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.39%. Comparing base (830ff9d) to head (8cfcb49). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ee/server/service/devices.go 40.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #24026 +/- ## ========================================== - Coverage 63.39% 63.39% -0.01% ========================================== Files 1579 1579 Lines 149918 149923 +5 Branches 3766 3766 ========================================== + Hits 95044 95046 +2 - Misses 47301 47303 +2 - Partials 7573 7574 +1 ``` | [Flag](https://app.codecov.io/gh/fleetdm/fleet/pull/24026/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/fleetdm/fleet/pull/24026/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm) | `64.26% <40.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fleetdm#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: