Make scripts editable in Fleet UI

[eugkuo]

Goal

User story
As an admin,
I want to be able to edit scripts within the Fleet UI
so that I can quickly fix typos or other errors without having to download and re-upload the script.

Key result

Original requests

• 23767

Context

• Product designer: @eugkuo

Changes

Product

• [ ] UI changes: Figma | Prototype
• [ ] CLI (fleetctl) usage changes: TODO
• [ ] YAML changes: TODO
• [ ] REST API changes: TODO
• [ ] Fleet's agent (fleetd) changes: TODO
• [ ] Activity changes: TODO
• [ ] Permissions changes: TODO
• [ ] Changes to paid features or tiers: TODO
• [ ] Other reference documentation changes: TODO
• [ ] Once shipped, requester has been notified
• [ ] Once shipped, dogfooding issue has been filed

Engineering

• [ ] Feature guide changes: TODO
• [ ] Database schema migrations: TODO
• [ ] Load testing: TODO

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

• Requires load testing: TODO
• Risk level: Low / High TODO
• Risk description: TODO

Manual testing steps

1. Step 1
2. Step 2
3. Step 3

Testing notes

Confirmation

1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.

[eugkuo]

FYI @noahtalerman I've added this prototype to show editing scripts from the script library page.

[eugkuo]

FYI (to discuss) @noahtalerman I've updated the design and the prototype.

After thinking about this a little bit, I wanted to be clearer to people when text has been entered into the edit field (in case they accidentally did something.

So when people first hit the modal, the button at the bottom is . If they enter text or delete text the button changes to with a secondary button.

A few questions:

1. Do we do any checks on the syntax or formatting of scripts when people are entering text or saving it?
2. What type of error mesesaging could we see here? I've rendered a success message. If we have standard messages for this lmk (and if we have standard messages can I say "use standard messaging" without rendering them?

Thanks! Hope you had a great Thanksgiving!