search

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.11k stars 429 forks source link

Language consistency around delete/remove #2758

Open rlynnj11 opened 3 years ago

rlynnj11 commented 3 years ago

Fleet version : 4.4.X onward at least

Fleet tier Premium

User role (Which role are you assigned in Fleet? (Admin, Maintainer, or Observer)): All

Operating system macOS 11.6

Web browser Chrome 94

🧑‍💻  Expected behavior

Language consistency throughout the app

💥  Actual behavior

Possible inconsistent use of "delete" vs "remove" language throughout Fleet.

instances of DELETE: users, teams, queries, hosts instances of REMOVE: policies, schedules

More info

This ticket requires a decision to be made about whether vocabulary needs to be changed anywhere, and if it does, this is a purely cosmetic change.

RachelElysia commented 3 years ago

My understanding of delete vs. remove was that delete means it's gone forever, vs. remove is related to something, a query, that is scheduled and can be added back easily.

noahtalerman commented 3 years ago

delete means it's gone forever, vs. remove is related to something, a query, that is scheduled and can be added back easily

Rachel, this is correct.

@rlynnj11 I removed the ":bug" label because "delete" and "remove" is the expected language as of now. Adding the "idea" label so that this issue is tracked for later discussion.