Audit helper functions - Githubissues

fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)

https://fleetdm.com

Other

3.09k stars 426 forks source link

Audit helper functions #3578

Open lukeheath opened 2 years ago

lukeheath commented 2 years ago

We have a large set of helper functions spread across 17 helper files. We need to audit these for the following:

Is it still necessary for us to maintain our own helper function in all cases? Could we switch to ES6/ES6 methods? If not, can we use lodash?

In many cases, these functions were created before ES6 was widely used.
In some cases, these helper functions provide useful functionality on top of lodash functions. (like debouce())

Hanaffi commented 2 years ago

@lukeheath Is it for internal employees only?

lukeheath commented 2 years ago

@Hanaffi We're always happy to receive community contributions! Feel free to put in a PR for any aspect of this and I will take a look. Thanks for your interest in contributing!

Hanaffi commented 2 years ago

@lukeheath Thanks! Can you assign me?