fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.12k stars 431 forks source link

Add ability to disable browser extensions and atom packages #5842

Open noahtalerman opened 2 years ago

noahtalerman commented 2 years ago

Users that manage hosts that each have 10,000+ system users are concerned with the performance of the software inventory feature.

Note you can see how many system users are on a host by running the SELECT * FROM users query against one of your hosts.

This is because, in order to collect software, Fleet runs a software collection query on each host. This query collects all users (SELECT * FROM users). This is because joining with the users table is required to retrieve browser extensions and atom packages.

For example, the Linux software collection query collects all users to join with firefox_addons, chrome_extensions, and atom_packages.

Goal

As a Fleet user that manages hosts that each have 10,000+ system users, I want to be able to disable browser extensions and atom packages in software inventory so that I can safely collect software data from all my hosts.

How?

Notes

noahtalerman commented 2 years ago

Users that manage hosts that each have 10,000+ system users

This is the approach the Fleet team would like to take in order to allow customers, that fit the above description, to turn on software inventory.

@tgauda can you please let the customer, that reported this issue, know that this is the current strategy?

The following is the internal Slack thread with this customer that describes the issue: https://fleetdm.slack.com/archives/C03AE5T2EQ0/p1652816692500489

noahtalerman commented 2 years ago

@zwass: I'll follow up with Tomas to wait on writing code to address this issue. This is because we'd like to discuss this issue in tandem with the following issue: https://github.com/fleetdm/fleet/issues/5939

zwass commented 2 years ago

Recent performance improvements in the users table in osquery could make this no longer necessary. I'm unassigning from myself as it is not a current priority.