Keyboard shortcut for submitting query

[GuillaumeRoss]

Goal

After writing a query in Fleet, I want to be able to run my query by using my keyboard.

How?

• Use GitHub's shortcuts:

Tasks

• [ ] Add hot keys to both the "Query" and "Policies" new query and edit existing policy pages.
  • ⌘-enter (cmd-enter) for mac.
  • ctrl-enter for Windows and Linux.

[noahtalerman]

@lukeheath heads up, I assigned you this issue for spec'ing.

[RachelElysia]

These as well

[RachelElysia]

Adding and editing a pack as well

[RachelElysia]

Collaborated on a call with @xpkoala

Other Keyboard issues:

Create a new query

• [ ] get stuck in query editor, no way out
• Potential solutions
  • escape
  • command enter
  • tab to escape local fix only (so it's not affecting agent options/yaml or other code editors)

Select targets page

• [ ] Tabbing through elements is out of order (and inconsistent across on safari beta)
• [ ] The green Run highlight deprioritized ticket #7795 is an issue on select targets page as well, need this styling change to be addressed, changed to new styling now will solve this issue
• [ ] Unable to select specific hosts using keyboard (only search but not select)
• [ ] Searching hosts on host page, can come up with 46 hosts, but searching in select targets you only see the top 10, is this the intended behavior of the select targets dropdown?

Query results page

• [ ] Highlighting for Green "Run again" is not happening, is this going to be a styling change also
• [ ] Reed said one may argue that the stop button is auto-focused so someone can hit enter to stop the query from running
• [ ] Can't even highlight "Errors" tab by tabbing through page with errors

@lukeheath This experience has a lot of questions that need confirmation to proceed. Reed and I chatted for an hour related to what the UX should feel like on these pages with a keyboard. He said the shortcuts for command enter to run a query doesn't make sense to implement unless MVP of other implementations are in place. Would like your thoughts on how to to proceed for anything with a checkbox above.

@xpkoala offered to create a loom video on all these things https://www.loom.com/share/685582eb8ad74cd582fc3e440f9c717a

[RachelElysia]

@noahtalerman This landed on my plate and so I paired up with @xpkoala -- he was suggesting that it's unintuitive to progress to run query if the user doesn't know where they're at in the form which is related to this deprioritized ticket: https://github.com/fleetdm/fleet/issues/7795

Suggestions?

[lukeheath]

@RachelElysia Thank you both for your diligence in digging into this!

@noahtalerman Please take a look at the loom above. The product issue pointed out is that even if we make the "edit query" screen proceed with cmd+enter, the following "select targets" screen is not optimized for keyboard navigation and requires mouse interaction. So, if the goal is to be able to run the query without touching the mouse, we need to expand the ticket to include updating the "select targets" screen, as well. I see three options:

1) We proceed with the ticket as spec'd and only implement the cmd+enter feature on the "edit query" screen. This option accepts the "select targets" screen requires mouse interaction.

2) We expand the ticket to include the "select targets" screen, which takes this ticket from a 3 to a 5-8.

3) We defer this ticket and remove it from the current release.

What do you think? Since this was a low-priority ticket, I'm inclined toward option three.

[noahtalerman]

We defer this ticket and remove it from the current release.

@lukeheath This makes sense to me. Can you please remove the issue from the release board?

The goal is to be able to run the query without touching the mouse. This goal is not a high enough priority to spend 2-3 days on (5-8 points).

Since this was a low-priority ticket, I'm inclined toward option three.

I agree.

[noahtalerman]

@RachelElysia @xpkoala thank you for digging into this!

[lukeheath]

@noahtalerman Sounds good.

@RachelElysia We are deprioritizing this issue for now.