Closed lukeheath closed 1 year ago
@noahtalerman the old spec mentioned:
Add new configuration option apple_bm_default_team. Can be set via config yaml fleetctl apply, command line flag, or environment variable.
Note that this is not a server config, but an app one, so it cannot be set by command-line flag nor environment variable. Presumably there will also be a frontend ticket to add a UI option to set it? Otherwise it would be just via fleetctl apply
and a yaml file.
@noahtalerman about this validation:
Verify that the team exists. Reject if the team does not with an error message.
It's fine to validate this when the default team is set, but nothing prevents the team from being deleted afterwards. It doesn't impact this ticket, but worth mentioning, as the ticket that will use this config option will also have to validate that the team still exists.
Estimate: 2
Note that this is not a server config, but an app one, so it cannot be set by command-line flag nor environment variable.
Right. I think "Can be set via config yaml fleetctl apply, command line flag, or environment variable" was a typo in the old spec.
Presumably there will also be a frontend ticket to add a UI option to set it?
@mna that's right. The UI is illustrated here in Figma. Screenshot is below:
It's fine to validate this when the default team is set, but nothing prevents the team from being deleted afterwards. It doesn't impact this ticket, but worth mentioning, as the ticket that will use this config option will also have to validate that the team still exists.
@mna I think this makes sense.
Verify that the team exists. Reject if the team does not with an error message.
What I meant by this^ is whenever the user runs fleetctl apply
, Fleet should validate that the team specified in mdm.apple_bm_default_team
exists. If it doesn't exist, the user sees an error.
What I meant by this^ is whenever the user runs fleetctl apply, Fleet should validate that the team specified in mdm.apple_bm_default_team exists. If it doesn't exist, the user sees an error.
@noahtalerman yes, definitely, that's how I understood it too and I included this validation in the spec, just wanted to point out that the team could still be deleted later on so the code that applies that setting (not in the scope of this ticket) should also make that validation.
just wanted to point out that the team could still be deleted later on so the code that applies that setting (not in the scope of this ticket) should also make that validation.
Ah, ok. Makes sense. Thanks.
Connect new hosts to Fleet Team enrolls them quickly and neat Safety and security
Goal
As a Fleet admin, I want to be able to connect Fleet to my Apple Business Manager account so that I can automatically enroll new, macOS hosts to Fleet. This way, I can order a new MacBook that automatically appears in Fleet when it's unboxed.
Related
8725
Requirements
Tasks
1
mdm.apple_bm_default_team
.fleetctl apply
, or (eventually) via the UI.PATCH /config
endpoint is the corresponding API endpoint that will apply this new config.GET /config
if set (which it should do automatically)Example
2
transparency_url
config option)3
apple_bm_default_team
configuration option.4
fleetctl get mdm-apple-bm
to return the configured default team (https://github.com/fleetdm/fleet/issues/8726)