Include MDM pending hosts in hosts list and MDM card

lukeheath commented 1 year ago

Goal

As a user in the Fleet UI, I want to see macOS hosts waiting to be automatically enrolled in Fleet so that I can change this host's team before the device user unboxes the host.

Requirements

See requirements in parent epic.

Figma

https://www.figma.com/file/hdALBDsrti77QuDNSzLdkx/%F0%9F%9A%A7-Fleet-EE-(dev-ready%2C-scratchpad)?node-id=9868%3A316280

Tasks

1

[x] Update MDM card on dashboard.
Update “Enrollment” tab name to “Status”.
Update card subheader copy.
Update “Enrolled” to “On” and “Unenrolled” to “Off”
New copy for “Pending,” “On (automatic)” and “On (manual)” tooltips. Reference Figma for tooltip text.
New copy for "Off" (See Rachel<>Noah comments on this issue)

2

[x] Apply same copy updates where "MDM Enrollment" is shown on Host Details and Device User page.
Update “Enrolled” to “On” and “Unenrolled” to “Off”
Add tooltip to Host Details and Device User page (See Rachel<>Noah comments on this issue)

3

[x] Ensure the manage hosts page is correctly displaying pending hosts.
GET /hosts will be returning pending hosts, but with most fields set to null or an empty-like value if the column is non-nullable.
We can determine which hosts are pending because they will not have an enrolled_at timestamp.
Pending hosts should not be linked to the host details page, because we have no additional details to show until the device enrolls in Fleet.

4

[x] Add new "MDM Status: Pending" hosts filter.
URL param will be mdm_enrollment_status=pending
Add a new “MDM status: Pending” filter. Tooltip is displayed on hover.
Update “MDM enrolled (automatic)” to “MDM status: On (automatic)”
Update “MDM enrolled (manual)” to “MDM status: On (manual)”
New copy for “MDM status: On (automatic)” and “MDM status: On (manual)” tooltips. (see Figma)
Add MDM status and MDM server URL columns. These columns are off by default for new Fleet instances.
Column headers have no sort.
Add tooltips to column headers.
Add tooltips to host name when in pending status.
See Figma for tooltip text.
New copy for "MDM status: Off" (See Rachel <> Noah comments on this issue)

5

[x] Update MDM Status and MDM Server URL columns.
Add empty state --- when field is empty.

lukeheath commented 1 year ago

@noahtalerman Figma has a dev note saying we should apple the same MDM card changes to host details and my device, but there is no MDM card on those pages. Please let me know if I'm missing something. Maybe you're thinking of the Munki issues card?

noahtalerman commented 1 year ago

apple the same MDM card changes to host details and my device

@lukeheath Ah, I meant the MDM enrollment and MDM server URL items on the Host details and My device pages.

Screenshot of these items is below:

Maybe a better dev note would be something like "Make this change to all places where MDM enrollment and MDM server URL is displayed in the UI" ?

Apologies for the lack of clarity.

noahtalerman commented 1 year ago

Add MDM status and MDM server URL columns. These columns are off by default for new Fleet instances.

Hey @lukeheath we'd like to update (and provide more detail) for this requirement.

The MDM status and MDM server URL columns don't have sort
The columns titles for MDM status and MDM server URL show tooltips on hover. Those tooltips are shown in a separate Figma page here: https://www.figma.com/file/hdALBDsrti77QuDNSzLdkx/%F0%9F%9A%A7-Fleet-EE-(dev-ready%2C-scratchpad)?node-id=11728%3A323308
The MDM status and MDM server URL columns can have empty states. When to show the empty states is explained in Figma here: https://www.figma.com/file/hdALBDsrti77QuDNSzLdkx/%F0%9F%9A%A7-Fleet-EE-(dev-ready%2C-scratchpad)?node-id=11728%3A323308

At some point, I filed a separate issue that covers the above^ requirements: #9073

Please feel free to close #9073 if you think it makes sense.

gillespi314 commented 1 year ago

FWIW, I hacked together some of the frontend of specified in this ticket as I was working on the backend portion of 8879 (mostly for my own local dev purposes). I published a branch with my frontend work in case it might be a helpful jumpstart for y’all when you actually pick up the ticket.

lukeheath commented 1 year ago

@gillespi314 Thank you! @RachelElysia will be working on this next sprint, so the two of you will work together to close out this epic.

RachelElysia commented 1 year ago

Several things to consider, @noahtalerman maybe you can clarify:

The dashboard mdm status "off" row is the only one that doesn't have a tooltip, but the host table filter pill "off" does. Do we want to make them consistent with both having a tooltip?
Currently the host details page does not show MDM enrollment section if mdm enrollment is off/unenrolled. Do we want to continue hiding this section for that edge case?
Currently the host details page does not show a tooltip for the MDM enrollment section. Do we want to add a tooltip to the host details page / device user page to be consistent with MDM status tooltips on the Dashboard and Manage Host Page?

PR for this should be ready by tomorrow

noahtalerman commented 1 year ago

the host table filter pill "off" does

@RachelElysia what's the tooltip copy for this? I think adding the same tooltip to "off" of the dashboard makes sense. I just want to make sure I get a chance to look at the tooltip copy.

the host details page does not show MDM enrollment section if mdm enrollment is off/unenrolled. Do we want to continue hiding this section for that edge case?

No. Let's show MDM status on the Host details page even if it's off. MDM status should only show up for Macs for now.

Do we want to add a tooltip to the host details page / device user page to be consistent with MDM status tooltips on the Dashboard and Manage Host Page?

Yes. This is a good idea. Let's add tooltips to MDM status on the Host details page.

RachelElysia commented 1 year ago

@noahtalerman

Current Tooltip for "MDM status: Off" filter on manage host page: <span className={`tooltip__tooltip-text`}> Hosts not enrolled to <br /> an MDM solution. </span>
sg, will update
sg, will update

noahtalerman commented 1 year ago

Tooltip for "MDM status: Off"

@RachelElysia can we update to the copy to this? "Hosts with MDM off don't receive macOS settings and macOS update encouragement."

This way the tooltip does this: Tells the user what happens to hosts with MDM off.

fleet-release commented 1 year ago

” to “MDM status: On (automatic)...”

Update “MDM enrolled (manual)...” to “MDM status: On (manual)...”

Bright cloud cities shine,
Viewing hosts pending in Fleet,
Ease of management.

fleetdm / fleet