fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.01k stars 418 forks source link

Add API endpoints to create, list, get, and delete profiles globally and per team #9586

Closed lukeheath closed 1 year ago

lukeheath commented 1 year ago

Related user story

8360

Task

Figma

https://www.figma.com/file/hdALBDsrti77QuDNSzLdkx/%F0%9F%9A%A7-Fleet-EE-(dev-ready%2C-scratchpad)?node-id=10517%3A316027&t=gNbRhoIo5iC2OBaX-0

lukeheath commented 1 year ago

Hey team! Please add your planning poker estimate with Zenhub @gillespi314 @mna @roperzh

roperzh commented 1 year ago

Is there an API endpoint required to edit profiles? What does product mean in the user story when they say profiles are editable in the CLI? Does that just mean you can add/delete them via YAML?

@lukeheath there's no way to edit profiles in the UI so an API endpoint shouldn't be necessary. Editing via the CLI means that if a profile is provided with the same PayloadIdentifier of an existing one it is "replaced"

lukeheath commented 1 year ago

@roperzh Thanks for the clarification. I've removed the question from the description.

noahtalerman commented 1 year ago

@gillespi314 I added a new error state for when the user tries to add an encrypted profile: "Couldn’t upload. The file should be unencrypted."

For now, I'm assuming we're able to detect this case and show a specific error message.

Link to the UI in Figma is here: https://www.figma.com/file/hdALBDsrti77QuDNSzLdkx/%F0%9F%9A%A7-Fleet-EE-(dev-ready%2C-scratchpad)?node-id=13353%3A189397&t=qiR2INRpziFD2o9o-1

EDIT: I learned from Roberto that "unsigned" is different from "unencrypted"

Is "unsigned (unencrypted)" the correct language? Moreover, is unsigned the same as unencrypted?

I'm using "unsigned" language because the iMazing profile editor uses this language when the user saves a profile:

noahtalerman commented 1 year ago

@gillespi314 heads up, I edited the above error message for when a user tries to add an encrypted profile.

I learned from @roperzh that unsigned is not the same as unencrypted.

fleet-release commented 1 year ago

Simple management tools, Actions are easy and clear, Achieve more, faster.