fleetdm / fleet

Open-source platform for IT, security, and infrastructure teams. (Linux, macOS, Chrome, Windows, cloud, data center)
https://fleetdm.com
Other
3.01k stars 418 forks source link

Differentiate request_csr endpoint error codes for semantically invalid email vs other errors #9588

Closed jacobshandling closed 1 year ago

jacobshandling commented 1 year ago

When POSTing to /fleet/mdm/apple/request_csr, the endpoint should return 4.xx (422?) for semantically invalid emails instead of the current 5.xx.

background:

the UI needs to see two options for error responses:

The endpoint currently returns 422 for syntactically invalid emails, but 5.xx for semantically invalid emails, as well as for other server errors.

lukeheath commented 1 year ago

@eashaw Do you have the capacity to take this on this week?

lukeheath commented 1 year ago

@eashaw My mistake; this is on the Fleet API side, not fleetdm.com. Please disregard.

fleet-release commented 1 year ago

Clouds of worry drift away Semantic errors made clear Fleet saves the day