flekschas / enhancer-gene-vis

A tool for visualizing ABC enhancer-gene connections in the context of genetic variants.
https://flekschas.github.io/enhancer-gene-vis
Apache License 2.0
12 stars 4 forks source link

Remove dependence of RidgeTrack on explicit index ordering of DNA Accessibility data #43

Closed riyavsinha closed 2 years ago

riyavsinha commented 2 years ago

State Before DNA accessibility component passes an explicit number[] that tells the RidgePlot track which indices of TileData to render in order. This numeric array must be manually maintained and does not scale to different orderings or selections, since DNA accessibility only modifies the original constant array by filtering values from it.

State Now DNA accessibility component constructs a string[] of the cell sample names in order, from the existing cell stratification view configuration (thus keeping them in sync). The RidgePlot will use the order of sample names to match to the tileset data fetched, and appropriately construct the ordering for the data to display.

riyavsinha commented 2 years ago

also accidentally ran lint fix which caused a bunch of unnecessary changes.