Closed insertmike closed 1 year ago
See my reply to the ticket. Removing the peer dependency should break the bundle because the bundle does not contain regl
nor pubsub-es
.
I'm closing this PR as I'm not planning to remove the peer dependencies. Since npm version 7
peer dependencies are installed automatically so all the user has to do is npm i regl-scatterplot
. I've sent the recommended minimum version of npm to 7
in package.json
. Supporting older version of npm is not really my focus at this point.
And the reason to keep regl
and pub-sub-es
as peer dependencies is simply because when used in larger application, one might want to render other things with regl and use pub-sub-es for other communication. Removing them as a peer dependency and bundling them together with regl-scatterplot would mean that any wrapper application has two copies if regl
and pub-sub-es
. That'd not be ideal.
Please let me know if I'm missing something and I'm happy to reopen the PR.
Remove duplicate peer-dependencies which are listed as dependencies as well.
Description
Remove duplicate peer-dependencies which are listed as dependencies as well.
Fixes #128
Checklist