flekschas / regl-scatterplot

Scalable WebGL-based scatter plot library build with Regl
https://flekschas.github.io/regl-scatterplot/
MIT License
184 stars 21 forks source link

fix: Inability to draw with active filter #137

Closed insertmike closed 1 year ago

insertmike commented 1 year ago

Adds preventFilterReset option to ScatterplotMethodOptions['draw'] to allow re-drawing while keeping the current active filter.

Description

What was changed in this pull request?

Why is it necessary?

Fixes #136

Checklist

insertmike commented 1 year ago

@flekschas Does this look good?

insertmike commented 1 year ago

Thanks for your dedication and review! @flekschas

I went through your code review and tried addressing all comments. Let me know if that works!

insertmike commented 1 year ago

Thanks for addressing my comments! The PR looks good now! @flekschas

Amazing, thank you! Looking forward to more PR's. Are we planning on having a release anytime soon?

flekschas commented 1 year ago

Yes, a release is imminent. Just putting another fix together