feat: add support for linear and constant point scaling via a new property called `pointScaleMode`

abast commented 1 week ago

Write one to two sentences summarizing this PR

This introduces two new modes: (1) point size is kept constant, independent of zoom (2) point size is proportional to zoom.

What was changed in this pull request?

the getPointScale method in index.js
an additional attribute POINT_SCALE_MODE was introduced, which allows to switch between three modes: 'constant', 'proportional' and 'default.

Why is it necessary?

Fixes #169

Checklist

[x] Provided a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties")
[ ] CHANGELOG.md updated
[ ] Tests added or updated
[ ] Documentation in README.md added or updated
[ ] Example(s) added or updated
[ ] Screenshot, gif, or video attached for visual changes

flekschas commented 6 days ago

I made a bunch of changes to address most outstanding issues. I'll commit them later today or tomorrow

abast commented 6 days ago

Thanks for addressing most of the outstanding issues! This is my first time working with javascript, so also thanks for the warm and encouraging response :)

flekschas commented 6 days ago

I can't figure out how to push to your branch so I'll merge your branch into a new one I just created and then I'll push my changes onto the new branch :)

flekschas / regl-scatterplot

feat: add support for linear and constant point scaling via a new property called `pointScaleMode` #194

Checklist