flightaware / Tcl-bounties

Bounty program for improvements to Tcl and certain Tcl packages
104 stars 8 forks source link

Add "after at" to schedule events for a specific time #2

Open SpaceManiac opened 7 years ago

SpaceManiac commented 7 years ago

A patch has been submitted upstream:

https://core.tcl.tk/tcl/tktview/2953b1b26b58c887435b74923ccef1712ad4b614

jima00 commented 7 years ago

Any chance this could be coordinated with efforts towards http://www.tcl.tk/cgi-bin/tct/tip/302 ?

eviltwinskippy commented 7 years ago

For the interim, there is a pure-tcl module for tcllib to do roughly this task: http://core.tcl.tk/tcllib/doc/trunk/embedded/www/tcllib/files/modules/cron/cron.html

kennykb commented 7 years ago

@jima00 - Yes, I would imagine that we'd want to combine this functionality with 302. My only trepidation is that it changes the semantics of [after] for all the programs that are using something like the 'cron' module to get the desired functionality. [at] really does need to be affected by changes in the system clock.

resuna commented 7 years ago

It seems like implementing "after at" and then giving some time for programs currently using "after" to schedule wallclock events to switch to "after at" would be a path to making TIP #302 implementable.

So I think this should be submitted as a new TIP with cross-reference to TIP #302.

sebres commented 7 years ago

I've provided artificial PR sebres/tcl#4, that fully implements this (together with TIP #302 and many, many other things.

If I get a bit time, and TCT does not see absolute no-go for it (because I've several doubts about), I'll make decent rebase to fossil (with commit-history and review). @flightaware I would like to know your statement also.

resuna commented 7 years ago

That looks really impressive. I’ll have to have a sitdown and look it all over. Hopefully it will be possible to convince the TCT.

From: "Serg G. Brester" notifications@github.com Reply-To: flightaware/Tcl-bounties reply@reply.github.com Date: Thursday, June 29, 2017 at 2:56 PM To: flightaware/Tcl-bounties Tcl-bounties@noreply.github.com Cc: Peter da Silva peter.dasilva@flightaware.com, Comment comment@noreply.github.com Subject: Re: [flightaware/Tcl-bounties] Add "after at" to schedule events for a specific time (#2)

I've provided artificial PR sebres/tcl#4https://github.com/sebres/tcl/pull/4, that fully implements this (together with TIP #302<www.tcl.tk/cgi-bin/tct/tip/302.html> and many, many other things.

If I get a bit time, and TCT does not see absolute no-go for it (because I've several doubts about), I'll make decent rebase to fossil (with commit-history and review). @flightawarehttps://github.com/flightaware I would like to know your statement also.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/flightaware/Tcl-bounties/issues/2#issuecomment-312086769, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAF0OoYMRiQVS4gqCZtaNNmFQbLUR5ziks5sJAGDgaJpZM4K2afA.

sebres commented 7 years ago

I've extended test-cases a bit, and have provided a performance comparison for above-mentioned branch, if interesting https://github.com/sebres/tcl/pull/4#issuecomment-312252977

sebres commented 7 years ago

Reintegrated resp. back-ported as 8.6 based branch in sebres-8-6-event-perf-branch