search

flopezag / qa-fiware-tutorials

“As ironic as it seems, the challenge of a tester is to test as little as possible. Test less, but test smarter.” — Federico Toledo
Apache License 2.0
1 stars 2 forks source link

Refactoring code due to 6xx tutorials and checking all the rest are w… #28

Closed flopezag closed 2 years ago

flopezag commented 2 years ago

Description

Refactoring the features and some python steps after merging 601 and 602 tutorials.

Test

Checked the execution of all the tests

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [2756234](https://dashboard.gitguardian.com/incidents/2756234?occurrence=38108349) | Base64 Basic Authentication | 79756000df075905f33909b3d9d38d83ad403d3f | features/405.XACML_Rules-based_Permissions.feature | [View secret](https://github.com/flopezag/qa-fiware-tutorials/commit/79756000df075905f33909b3d9d38d83ad403d3f#diff-f46c557713bf6ecccc3e13c3375ebeb993ee8bf1df0936f0da9eef12ee1f6feaL58) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/base64_basic_auth#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

jicarretero commented 2 years ago

LGTM